refactor(ui): Use an iterator instead of Vec to represent events
#4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes `TimelineStateTransaction::add_remote_events_at` to take an `IntoIterator<Item = Into<SyncTimelineEvent>>` for `events`. In the current code, it saves one `iter().map(Into::into).collect::<Vec<_>>()`, but it will save another one when we will support `VectorDiff`s coming from the `EventCache`. It also avoids to allocate a vector to pass new events (this mostly happens in the test, but it can happen in real life).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4361 +/- ##
==========================================
+ Coverage 85.10% 85.14% +0.03%
==========================================
Files 280 280
Lines 30535 30539 +4
==========================================
+ Hits 25988 26001 +13
+ Misses 4547 4538 -9 ☔ View full report in Codecov by Sentry. |
Hywan
requested review from
poljar and
bnjbvr
and removed request for
a team and
poljar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #3512)
This patch changes
TimelineStateTransaction::add_remote_events_atto take anIntoIterator<Item = Into<SyncTimelineEvent>>forevents. In the current code, it saves oneiter().map(Into::into).collect::<Vec<_>>(), but it will save another one when we will supportVectorDiffs coming from theEventCache.It also avoids to allocate a vector to pass new events (this mostly happens in the tests, but it can happen in real life).
EventCachestorage #3280