chore(ui): Rename Timeline::subscribe_batched to Timeline::subscribe
#4585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes useless `trace!` calls.
Hywan
requested review from
andybalaam and
stefanceriu
and removed request for
a team and
andybalaam
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4585 +/- ##
==========================================
- Coverage 85.40% 85.40% -0.01%
==========================================
Files 286 286
Lines 32258 32255 -3
==========================================
- Hits 27550 27546 -4
- Misses 4708 4709 +1 ☔ View full report in Codecov by Sentry. |
Hywan
force-pushed
the
chore-ui-timeline-subscribe-batched-to-subscribe
branch
from
3ca444f to
513dbd8
Compare
This patch renames `Timeline::subscribe_batched` to `Timeline::subscribe`. Since the `Timeline::subscribe` method has been removed because unused, it no longer makes sense to have a “batched” variant here. Let's simplify things!
Hywan
force-pushed
the
chore-ui-timeline-subscribe-batched-to-subscribe
branch
from
513dbd8 to
e7b6cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames
Timeline::subscribe_batchedtoTimeline::subscribe. Since theTimeline::subscribemethod has beenremoved because unused, it no longer makes sense to have a “batched”
variant here. Let's simplify things!
Timeline::subscribe#4567.EventCachestorage #3280.