feat(base): Add EventCacheStore::filter_duplicated_events
#4659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds and implements the `EventCacheStore::filter_duplicated_events` method. It is implemented on the `MemoryStore` and the `SqliteEventCacheStore`. This method remove the unique events and reutrn the duplicated events.
Hywan
requested review from
andybalaam and
bnjbvr
and removed request for
a team and
andybalaam
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4659 +/- ##
==========================================
+ Coverage 85.69% 85.74% +0.04%
==========================================
Files 292 292
Lines 33620 33713 +93
==========================================
+ Hits 28812 28906 +94
+ Misses 4808 4807 -1 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Feb 12, 2025
Comment on lines
+514
to
+520
| let event_comte = event("comté"); | ||
| let event_brigand = event("brigand du jorat"); | ||
| let event_raclette = event("raclette"); | ||
| let event_morbier = event("morbier"); | ||
| let event_gruyere = event("gruyère"); | ||
| let event_tome = event("tome"); | ||
| let event_mont_dor = event("mont d'or"); |
| previous: Some(CId::new(0)), | ||
| new: CId::new(1), | ||
| next: None, | ||
| gap: Gap { prev_token: "brillat-savarin".to_owned() }, |
Comment on lines
+162
to
+165
| // If `events` is empty, we can short-circuit. | ||
| if events.is_empty() { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Can you if events.is_empty() { return; } at the top of the events, instead?
There was a problem hiding this comment.
No because we remove events one by one from events. When it's empty, we can stop iterating all other events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds and implements the
EventCacheStore::filter_duplicated_eventsmethod. It is implemented on theMemoryStoreand theSqliteEventCacheStore.This method remove the unique events and return the duplicated events.
On the
MemoryStore, it iterates over events only once.On the
SqliteEventCacheStore, it runs a single query (modulo the size of events to check, seechunk_large_query_over).EventCachestorage #3280EventCachelazy-loading #4632