feat(sqlite) Add an index on events.event_id and .room_id
#4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
jmartinesp and
bnjbvr
and removed request for
a team and
jmartinesp
23 tasks
bnjbvr
reviewed
Feb 19, 2025
bnjbvr
approved these changes
Feb 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4685 +/- ##
==========================================
+ Coverage 85.83% 85.85% +0.01%
==========================================
Files 292 292
Lines 33758 33763 +5
==========================================
+ Hits 28977 28987 +10
+ Misses 4781 4776 -5 ☔ View full report in Codecov by Sentry. |
This patch adds an index on `events.event_id` and on `events.room_id` so that queries on this column are faster. It mostly happens for the `Deduplicator`, which runs for every backwards pagination or sync. This patch also updates the query in `filter_duplicated_events` to sort event by their `chunk_id` and `position` so that the results are constant, it helps when testing.
Hywan
force-pushed
the
feat-sqlite-event-cache-event-id-index
branch
from
5364243 to
793a62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an index on
events.event_idand onevents.room_idso that queries on this column are faster. It mostly happens in theDeduplicator, which runs for every backwards pagination or sync.This patch also updates the query in
filter_duplicated_eventsto sort event by theirchunk_idandpositionso that the results are constant, it helps when testing.EventCachestorage #3280EventCachelazy-loading #4632