-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try open matrix: links before showing clients #223
Open
bwindels
wants to merge
18
commits into
main
Choose a base branch
from
danilafe/open-matrix-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bfcac9f
Try open matrix: links before showing clients
DanilaFe b17ce2e
Take the hiding code out of the root view model
DanilaFe b239f49
Track hidden status in OpenLinkViewModel
DanilaFe c26b8dc
Display a little message while trying to redirect
DanilaFe b8e07cd
Receive setTimeout as argument to help mocking
DanilaFe ee820b6
URLencode identifiers
DanilaFe 94f0883
Center text in addition to aligning
DanilaFe 820a090
Extract platform selection code from ClientView
DanilaFe a781c52
Add a view model for opening a client
DanilaFe c109293
Implement fleshed out design
DanilaFe 1179db5
Actually try to open matrix links
DanilaFe ff2d315
Rename OpenDefault to AutoOpen
DanilaFe 64129ca
Make the 'try again' button a link
DanilaFe bc9e091
Make less assumptions about auto redirect etc. in View code
DanilaFe b12f2fb
Minor design fixes (line height, punctuation)
DanilaFe 890673d
Avoid opening iOS
DanilaFe 86196d4
Add tentative copy change for 'click' and 'desktop'
DanilaFe 9a0d21d
Avoid using empty list to represent 'no element'
DanilaFe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need an
emitChange
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed not, since this is called from the
constructor
, and the views are only created afterwards. I don't think any handlers can be registered at the time of the constructor call? Maybe I'm misunderstanding.