Add the Cinny client #286
Merged
Add the Cinny client #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
thibaultamartin
requested changes
Oct 13, 2022
|
Can this be merged? |
|
Not quite, I would like to get @ajbura's input on the two unresolved threads (who to add as an author and the self assessed maturity of Cinny) |
|
okay, sounds reasonable :) |
kfiven
reviewed
Oct 26, 2022
3nt3
requested review from
ajbura and
thibaultamartin
and removed request for
thibaultamartin and
ajbura
|
can this be merged now? @thibaultamartin |
|
Just chiming in to see if there's anything that'd need changing before this can be merged @thibaultamartin |
Signed-off-by: 3nt3 <[email protected]>
Signed-off-by: 3nt3 <[email protected]>
Signed-off-by: 3nt3 <[email protected]>
Signed-off-by: 3nt3 <[email protected]>
thibaultamartin
force-pushed
the
main
branch
from
6c5cde3 to
008bc0d
Compare
thibaultamartin
approved these changes
Feb 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Cinny client.
Basically a cleaner version of #234.
I am not sure about the copyright of the SVG, it is licensed under
Creative Commons Attribution 4.0 International Licenseso it's okay to use, I just don't know where to put the attribution.