Report error responses as JSON #90
Merged
+210
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Feb 27, 2025
richvdh
requested changes
Feb 27, 2025
3 tasks
|
Clientside implementation is in element-hq/element-web#29378 |
richvdh
reviewed
Feb 28, 2025
richvdh
approved these changes
Mar 5, 2025
| func (s *submitServer) ServeHTTP(w http.ResponseWriter, req *http.Request) { | ||
| // if we attempt to return a response without reading the request body, | ||
| // apache gets upset and returns a 500. Let's try this. | ||
| defer req.Body.Close() | ||
| defer io.Copy(ioutil.Discard, req.Body) | ||
|
|
||
| if req.Method != "POST" && req.Method != "OPTIONS" { | ||
| writeError(w, 405, submitErrorResponse{"Method not allowed. Use POST.", ErrCodeMethodNotAllowed}) | ||
| writeError(w, 405, submitErrorResponse{Error: "Method not allowed. Use POST.", ErrorCode: ErrCodeMethodNotAllowed}) |
There was a problem hiding this comment.
You could have just done
writeError(w, 405, submitErrorResponse{"Method not allowed. Use POST.", ErrCodeMethodNotAllowed, ""})but this is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-meta#2732
This changes the following:
errordescribing the problem, and anerrcodewhich is machine readable.There is a docs/api.md to describe the change.
I have done this in a way that works, but I have no doubt this is horrendous Go code. Please be brutal.