Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-on-pr-merge #2794

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Update deploy-on-pr-merge #2794

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312924e
build: remove obsolete condition from deploy-on-pr-merge
michalmac Sep 30, 2023
26c9733
build: simplify maven server-id definition in deploy-on-pr-merge
michalmac Sep 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/deploy-on-pr-merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ on:
jobs:
deploy-snapshot:
name: deploy PR-labelled version
# for PR-labelled deployment -- only if closed by merging
if: github.event_name == 'push' || github.event.pull_request.merged == true
# only if PR closed by merging
if: github.event.pull_request.merged == true

runs-on: ubuntu-latest

Expand All @@ -25,7 +25,7 @@ jobs:
java-version: 17
distribution: 'zulu'
cache: 'maven'
server-id: ${{ github.event_name == 'push' && 'matsim-snapshots' || 'matsim-releases' }} #choose mvn repo
server-id: 'matsim-releases'
server-username: MAVEN_USERNAME
server-password: MAVEN_PASSWORD

Expand Down