Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing mode params #2823

Closed
wants to merge 1 commit into from
Closed

fix: missing mode params #2823

wants to merge 1 commit into from

Conversation

tkchouaki
Copy link
Contributor

The org.matsim.benchmark.Benchmark class runs the config file located in examples.scenarios.benchmark which uses the population file of the berlin scenario. However the config file for benchmark is missing some mode parameters that are necessary. They are added in this PR

@tschlenther
Copy link
Contributor

I think that if when you have resolved the conflicts we can merge this PR here ... :)

@mrieser
Copy link
Contributor

mrieser commented Nov 27, 2023

I think the Benchmark-class in the repository is from the old benchmark. The new benchmark essentially uses the Run-class from the OpenBerlin-scenario, which creates these missing parameters, see https://github.com/matsim-scenarios/matsim-berlin/blob/31af2a18d0c7a1eaf9e037a7ad7512c020999573/src/main/java/org/matsim/run/RunOpenBerlinScenario.java#L40

@tkchouaki tkchouaki closed this by deleting the head repository Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants