Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve chance of compiling hybridsim and protobuf contrib #2863

Merged
merged 4 commits into from
Oct 14, 2023

Conversation

marecabo
Copy link
Contributor

This change adds a plugin to the protobuf and hybridsim contrib that made them compile on our machines right after checking out the repo.
During the Code Sprint we talked about that these contribs beared some challenges in getting matsim compile from source successfully.

@marecabo marecabo force-pushed the hybridsim-protobuf-pom branch from 707e39f to 837dcb4 Compare October 13, 2023 09:21
@michalmac
Copy link
Member

We already have os-maven-plugin declared as extension. According to this readme, we should remove that declaration if we go for the "plugin" option.

BTW. Which IDE do you use?

@marecabo
Copy link
Contributor Author

I'm mostly using VS Code with its Extension Pack for Java.

Copy link
Member

@michalmac michalmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marecabo marecabo enabled auto-merge October 14, 2023 21:22
@marecabo marecabo merged commit 85cb852 into matsim-org:master Oct 14, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants