fix: order of drt discharge events #2926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalmac
reviewed
Nov 13, 2023
| @@ -41,6 +41,7 @@ public void install() { | |||
| protected void configureQSim() { | |||
| this.bind(DriveDischargingHandler.class).in( Singleton.class ); | |||
| addMobsimScopeEventHandlerBinding().to(DriveDischargingHandler.class); | |||
| addMobsimListenerBinding().to(DriveDischargingHandler.class); | |||
There was a problem hiding this comment.
This line should be replaced with:
this.addQSimComponentBinding(EvModule.EV_COMPONENT).to(DriveDischargingHandler.class);
Right now I doubt there is any event processed. Maybe this is why so may tests failed.
michalmac
reviewed
Nov 13, 2023
| @@ -104,6 +111,7 @@ public void handleEvent(VehicleLeavesTrafficEvent event) { | |||
| // (for instance, AUX discharging and battery charging modifies charge outside event handling | |||
| // (as MobsimAfterSimStepListeners) | |||
| //TODO In the long term, it will be safer to move the discharging procedure to a MobsimAfterSimStepListener | |||
| // -> has been implemented now as a hack /sebhoerl | |||
There was a problem hiding this comment.
While this change will definitely help with the order of events (which is good!), I was thinking about updating the SOC in the main thread (outside the event handling threads) to avoid race conditions (and also to have events deterministically ordered).
I will create a PR for moving the whole logic outside the event handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively simple fix for #2925: All discharging events are collected and only fired at the end of the simstep.
If somebody who is more familar with the
edrtcode could take over, that would be great :)