Remove CSS style from SimWrapper dashboard warning panel #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The embedded <style> tags are mostly OK, but one of them is interfering with the upcoming UI updates. Removing the `.dash-card-frame` CSS selector solves the problem. I tested on the existing site and it does not seem to cause problems.
|
It still works fine, but this line removed some margins, and I think it looks better without these in the old layout. |
|
@rakow ok thanks for checking. Let's delay this until the new site design stabilizes. Then we can re-evaluate the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded <style> tags used on the
summary.mdfile in the "Overview" panel are mostly OK, but one of them is interfering with the upcoming UI updates.Removing the
.dash-card-frameCSS selector solves the problem.I tested on the existing site and it does not seem to cause problems.