Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup small scale traffic generation #3032

Merged
merged 21 commits into from
Jan 2, 2024
Merged

Cleanup small scale traffic generation #3032

merged 21 commits into from
Jan 2, 2024

Conversation

rakow
Copy link
Contributor

@rakow rakow commented Jan 2, 2024

Various improvements for the small scale traffic generation

  • Don't read the shape file unnecessarily often
  • Use interfaces as types and not implementations
  • Improve run script, so that a separate config only for generation should not be necessary

rakow and others added 9 commits December 13, 2023 16:36
@rakow rakow requested a review from rewertvsp January 2, 2024 12:55
rewertvsp
rewertvsp approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@rewertvsp rewertvsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Christian for the changes. I also did some changes so that PR can be done.

@rakow rakow merged commit e315fe4 into master Jan 2, 2024
48 checks passed
@rakow rakow deleted the small-scale-traffic-impro branch January 2, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rewertvsp rewertvsp rewertvsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakow @rewertvsp