Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use EvBaseModule in EDrt #3065

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Conversation

nkuehnel
Copy link
Member

No description provided.

only use ev base module in edrt
@tschlenther
Copy link
Contributor

definetely a good way to quick-fix your problems.
As I am not heavily familiar with edrt, and especially not with your custom behavioral models:
Will your charging behavior for edrt work without the VehicleChargingHandler?
From the code, it reads like it wasn't meant to be working with DynAgents, in the first place. But, as it seems, it worked for DynAgents - until #2944. As @steffenaxer pointed out, we will probably need to come up with test cases for simualtins with both private and commercial (edrt) charging behavior.
But for a start, it would be good if you can confirm that both run successfully, when separated.

@steffenaxer
Copy link
Collaborator

Yes the VehicleChargingHandler is in my point of view not required anywhere for eDrts.

@tschlenther tschlenther enabled auto-merge January 23, 2024 07:49
@tschlenther tschlenther merged commit 71f9eae into matsim-org:master Jan 23, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants