Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let DefaultPassengerEngine respond to multiple modes #3083

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

sebhoerl
Copy link
Contributor

@sebhoerl sebhoerl commented Jan 30, 2024

We are about to prepare a PR for the shared_mobility contrib in which we want to reuse the DefaultPassengerEngine. However, we need to respond to two types of trips (owner and users in a peer-to-peer car-sharing system). For that purpose, we would like to push this PR which makes DefaultPassengerEngine respond to a configurable list of passenger modes with one service mode.

@michalmac Any concerns?

@sebhoerl sebhoerl requested a review from michalmac January 30, 2024 18:15
@michalmac
Copy link
Member

michalmac commented Jan 30, 2024

@michalmac Any concerns?

Not really. It is hard for me to have an opinion here. I do not know shared_mobility and I lack the context (mainly the motivation). Specifically, I do not know the difference between mode and departureMode.

I am open to discuss it further, but I am also fine with merging the proposed changes (assuming it solves your problem).

@sebhoerl
Copy link
Contributor Author

Hi Michal, ok, great. To give some background: We model two modes (being a car sharing user, no own car; and being a car sharing user with an own car) and all the cars in the system are handled via DVRP. This means that we want agents to drive around with cars from the "p2p" fleet when they depart either as "p2p:user" or "p2p:owner". So there are two modes that want to use one fleet (one DVRP mode).

@michalmac
Copy link
Member

Hi Michal, ok, great. To give some background: We model two modes (being a car sharing user, no own car; and being a car sharing user with an own car) and all the cars in the system are handled via DVRP. This means that we want agents to drive around with cars from the "p2p" fleet when they depart either as "p2p:user" or "p2p:owner". So there are two modes that want to use one fleet (one DVRP mode).

@sebhoerl Thanks for the background. Looks good to me.

@sebhoerl sebhoerl enabled auto-merge (squash) February 1, 2024 18:34
@sebhoerl sebhoerl merged commit a77fcef into master Feb 1, 2024
48 checks passed
@sebhoerl sebhoerl deleted the feat/departure-modes-for-dvrp branch February 1, 2024 18:46
nkuehnel pushed a commit to moia-oss/matsim-libs that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants