bugfix for XYToLink class #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakow
approved these changes
Feb 13, 2024
nkuehnel
pushed a commit
to moia-oss/matsim-libs
that referenced
this pull request
Feb 29, 2024
Co-authored-by: rakow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class ALWAYS passes an empty ActivityFacilities Object (FacilitiesUtils.createActivityFacilities()) when calling the algo XY2Links. This may be correct for plans and activities, which do not have an assigned facilityId. However, when activities already were assigned facilityIds, XY2Links will produce an error. If activities already were assigned facilityIds, we can assume that the scenario has an existing Facilities file, which can then be passed when running XYToLinks.