Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informed-mode-choice maintenance #3107

Merged
merged 13 commits into from
Feb 13, 2024
Merged

Informed-mode-choice maintenance #3107

merged 13 commits into from
Feb 13, 2024

Conversation

rakow
Copy link
Contributor

@rakow rakow commented Feb 13, 2024

PR includes cleanup and bug fixes for the informed-mode-choice contrib

  • Fix bug in GenerateChoiceSet when no subpopulation is present
  • Remove generics for mode options to simply the interface
  • Add method to pruning interface to allow more complex strategies

@rakow rakow enabled auto-merge (squash) February 13, 2024 09:24
@rakow rakow merged commit 8c4a877 into master Feb 13, 2024
48 checks passed
@rakow rakow deleted the imc-pruning branch February 13, 2024 09:30
nkuehnel pushed a commit to moia-oss/matsim-libs that referenced this pull request Feb 29, 2024
* add pruning method which allows more complexity

* add helper functions to plan candidate

* add tests and improved pruner interface

* fix compilation error and test

* add more callbacks and flexibility to the candidate pruner

* add default methods to pruning interface

* use new pruner methods in select single trip as well

* make subpopulation in generate choice set optional

* remove unneeded generics

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant