fix(drt): scheduling a same-index insertion before a prebooked request #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkuehnel
pushed a commit
to moia-oss/matsim-libs
that referenced
this pull request
Feb 29, 2024
matsim-org#3111) * fix: scheduling same-index insertion before prebooked request * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a bug when scheduling an insertion that has the same pickup and dropoff index (new dropoff directly following the new pickup along the stop sequence) just before a task with a prebooked pick-up. In that case, the begin time of the following pick-up task was illegally shifted to the past, or otherwise put, the fixed begin time of the prebooked task was not kept constant, thus blocking the vehicle for an unnecessary long time in a stop task. This PR fixes this issue, the performance of the prebooking scenario improves in the tests.