Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drt wait stats with .gpkg Geopackage #3159

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

nkuehnel
Copy link
Member

No description provided.

@nkuehnel
Copy link
Member Author

This PR is a follow-up to #3143 and changes the drt wait stats output to geopackage.
However, geopackage does not allow not having a CRS set. Would it be ok to skip the creation if the global config crs is not set? I'm not sure if most people actually set it.

Another idea would be to fall back to .shp again in this case. Or to default to WGS84 or sth...

Opinions?

Copy link
Member

@michalmac michalmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM However I do not use this functionality so I cannot assess it from the useability perspective.

@nkuehnel nkuehnel requested a review from luchengqi7 March 12, 2024 11:22
@luchengqi7
Copy link
Collaborator

It also looks good to me. Does that mean the .shp & related files. will be replaced by a single .gpkg file? That would be great! And will the commonly used visualisation softwares (e.g., VIA, QGIS, SimWrapper) also recognize the new file type?

@nkuehnel
Copy link
Member Author

@luchengqi7

Does that mean the .shp & related files. will be replaced by a single .gpkg file?

Exactly, it is just one .gpkg file.

That would be great!

It is! :D

And will the commonly used visualisation softwares (e.g., VIA, QGIS, SimWrapper)

I do not know about SimWrapper. However, I know that via and QGIS already support it.

@nkuehnel nkuehnel enabled auto-merge March 12, 2024 16:00
@nkuehnel nkuehnel merged commit d36e5f8 into matsim-org:master Mar 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants