Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move method to PTWaitingTimeEstimator interface #3174

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

marecabo
Copy link
Contributor

This change promotes the double estimateWaitingTime(List<? extends PlanElement> elements) method of the ScheduleWaitingTimeEstimator to its PTWaitingTimeEstimator interface as default implementation.

It was not part of the interface PTWaitingTimeEstimator before despite being public and being the most convenient way to use ScheduleWaitingTimeEstimator.

@sebhoerl Please let me know, if that is fine for you?

@marecabo marecabo requested a review from sebhoerl March 18, 2024 11:38
@sebhoerl
Copy link
Contributor

The stuff in utils is basically just for convenience, and I'm not sure where exactly you are using it and how. In any case, the interface should stay an interface without any logic, please avoid using default. But I'm fine with changing the interface to double estimateWaitingTime(List<? extends PlanElement> elements) or adding a second method to the interface.

@marecabo
Copy link
Contributor Author

Thanks for the feedback, I'll just keep the signature then in the interface.

@marecabo marecabo marked this pull request as ready for review March 18, 2024 12:15
@marecabo marecabo merged commit fd6f562 into matsim-org:master Mar 18, 2024
46 checks passed
@marecabo marecabo deleted the interface-PTWaitingTimeEstimator branch April 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants