Consolidate dvrp/drt/taxi zones #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhoerl
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Hi Nico, I quickly looked through it. Looks good from my side. It's a pity that some of the integration tests needed to be updated, but it's probably even better that this is uniform now. When I have the time, I will maybe implement a proper Euclidean hexagon grid ;-)
|
Tests run through on my local machine but some regression tests in the taxi contrib are still failing here. If anyone knows what the issue could be I would be glad for any support. |
|
Tested it on my mac m1. It runs on my machine. The test seems to fail in PopulationUtils.comparePopulations(expected, actual) with a different result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates dvrp and drt zones and makes zones available in the "commons" contrib.
It's definitely a breaking change.
Zone systems can be defined through zone system params (currently defined for square grid, gis input files and h3 grid). These zone system params can be used at different places. For example, DvrpTravelTimeMatrixParams and DrtZonalSystemParams both have a pointer to the same definition of ZoneSystemParams.
Some regression tests had to be updated, as the creation of square grid in dvrp and drt were slightly different.
It turned out to be more extensive then initially estimated, happy for comments and reviews.
It's now possible to have individual zone systems and sizes for dvrp travel time matrices which might come handy in large simulations with different reuirements of spatial accuracy.