fix: personMoney event reference lookup missing in EventsReader #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrawley-moia
force-pushed
the
fix-person-money-event-attr-ref
branch
from
7101124 to
636a229
Compare
|
Thanks Mark, looks good to me : ) |
nkuehnel
approved these changes
May 7, 2024
mfrawley-moia
added a commit
to moia-oss/matsim-libs
that referenced
this pull request
May 7, 2024
fix: personMoney event reference lookup missing in EventsReader (matsim-org#3258)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (Moia) discovered that the reference attribute for personMoney events was always null when parsed by the EventsReaderv1 class. I added a hopefully-appropriate unit test for it in EventsReadersTest, and adjusted the events.xml fixture accordingly.
Feedback is more than welcome! cc @nkuehnel @fzwick