Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for storing multiple DrtOptimizationConstraintsParams #3275

Merged
merged 6 commits into from
May 24, 2024
Merged

Allow for storing multiple DrtOptimizationConstraintsParams #3275

merged 6 commits into from
May 24, 2024

Conversation

marecabo
Copy link
Contributor

This is a follow-up to #3252 from @nkuehnel and me which allows to store multiple DrtOptimizationConstraintsParams in DrtConfigGroup while ensuring, there is always a default DrtOptimizationConstraintsParams present.

michalmac
michalmac approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@michalmac michalmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, LGTM as this is a continuation of another PR. (I haven't gone through the code thoroughly)

@nkuehnel nkuehnel marked this pull request as ready for review May 24, 2024 09:56
@marecabo marecabo merged commit 04a66fb into matsim-org:master May 24, 2024
47 checks passed
@marecabo marecabo deleted the multiple-drt-optimization-params branch May 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luchengqi7 luchengqi7 luchengqi7 approved these changes

@michalmac michalmac michalmac approved these changes

@sebhoerl sebhoerl Awaiting requested review from sebhoerl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marecabo @michalmac @luchengqi7 @nkuehnel