Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add router binding for complex request unscheduling #3340

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

nkuehnel
Copy link
Member

Hey @sebhoerl I was playing around with the prebooking module - not sure if this was really missing or it was supposed to be bound elsewhere but when choosing the complex request unscheduler in prebooking there was a (modal) binding missing for the LeastCostPathCalculator

This also crashed when choosing this unscheduler in the matsim-code-example

@nkuehnel nkuehnel requested a review from sebhoerl June 27, 2024 11:22
@sebhoerl
Copy link
Contributor

Hi @nkuehnel great, good catch, I guess we were testing it in some other set-up. The unit tests pass, but I think the complex unscheduler is never tested in an actual IT. If you are motivated, maybe you could modify for instance AbandonAndCancelTest::cancelLateTest to have a cancelLateWithComplexUnschedulerTest? :)

@nkuehnel
Copy link
Member Author

@sebhoerl please check if I got the test right.

I had to adapt the unscheduler because it was crashing wenn the cancelled pickup is the start waypoint of the vehicle entry (as it is the case in the test)

@sebhoerl
Copy link
Contributor

sebhoerl commented Jul 2, 2024

LGMT, thanks a lot :)

@nkuehnel nkuehnel merged commit 1dd4d60 into matsim-org:master Jul 2, 2024
47 checks passed
@nkuehnel nkuehnel deleted the addROuterToPrebooking branch July 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants