Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom travel time objects in CalculateSkimMatrices #3351

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Allow custom travel time objects in CalculateSkimMatrices #3351

merged 2 commits into from
Jul 4, 2024

Conversation

marecabo
Copy link
Contributor

@marecabo marecabo commented Jul 2, 2024

This change

  • splits the CalculateSkimMatrices.prepareAndCalculateNetworkMatrices() method such that there is a new variant, where a custom travel time object can be passed and
  • marks the eventsFilename arg as @Nullable such that is a bit more obvious, that it can be null and a FreeSpeedTravelTime is used in that case.

@marecabo marecabo marked this pull request as ready for review July 2, 2024 11:52
@steffenaxer steffenaxer enabled auto-merge July 4, 2024 05:51
@steffenaxer steffenaxer merged commit cb853ee into master Jul 4, 2024
49 checks passed
@steffenaxer steffenaxer deleted the skim-matrices-with-custom-travel-time-object branch July 4, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marecabo @steffenaxer