Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes a performance related update by @sebhoerl proposed here:
https://github.com/matsim-org/matsim-libs/tree/feat/improve-prebooking-stop-activity
in addition, it adds a check to notifyPassengersAreReadyForDeparture in the prebooking stop activity such that only pickups are queued if they are still contained in expectedPickups. Otherwise it can happen that a request is abandoned in the same second as it is picked up, throwing an exception:
With this fix, step 5 is extended to check whether the request is still contained in expected pickups, from which the agent should be removed in step 1, if abandonment happens in the same second.