Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use CsvOptions.detectDelimiter instead of hard coded ';' #3466

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

simei94
Copy link
Contributor

@simei94 simei94 commented Sep 9, 2024

No description provided.

@simei94
Copy link
Contributor Author

simei94 commented Sep 9, 2024

@frievoe97 please note that for a while now there is the method CsvOptions.detectDelimiter. Thus, there is no need to hard code delimiters for csv files when reading them. In most of our scenarios the delimiter in fact is ';', but for international scenarios this might not be true. I would like to ask you to use the detect delimiter method for the future.

@simei94 simei94 enabled auto-merge (squash) September 9, 2024 17:26
@simei94 simei94 merged commit 575e346 into master Sep 9, 2024
49 checks passed
@simei94 simei94 deleted the flexibilize-merge-noise-output branch September 9, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant