chore: default zoning params in DvrpTravelTimeMatrixParams #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nkuehnel
In the DvrpConfigGroup class, the getTravelTimeMatrixParams() method creates a DvrpTravelTimeMatrixParams on the fly if it doesn't already exist (meaning it wasn't in the XML input or it wasn't added by the script that created the DvrpConfigGroup).
However, when a DvrpTravelTimeMatrixParams is created in the above mentioned method, no ZoneSystemParams is created inside it. Which then causes a NullPointerException whenever the ZoneSystemParams is requested and used.
To address this, this PR continues the same approach of creating the params on the fly by creating a SquareGridZoneSystemParams with a cellSize of 200m, as was the default in the old implementation.