Adjust some carrier stuff #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rewertvsp
commented
Sep 30, 2024
rewertvsp
commented
- set the selected plan to null if when using clearPlans
- add method to check if all jobs are handled in the selected plan
kt86
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks. I just added one line in javaDoc, to clearify, that only the number of jobs is checked.
Two remarks for the future:
1.) This method should compare based on the job Ids and notify, which jobs are missing.
2.) I have the idea in my mind, to have some kind of "afterRun" consistency checker, where such a method could/should be called. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.