Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noise: filter activities spatially #3549

Merged
merged 3 commits into from
Nov 7, 2024
Merged

noise: filter activities spatially #3549

merged 3 commits into from
Nov 7, 2024

Conversation

tschlenther
Copy link
Contributor

Addresses #3548

This is just a draft with comment representing my idea how to do this

@tschlenther tschlenther self-assigned this Nov 7, 2024
@tschlenther tschlenther marked this pull request as ready for review November 7, 2024 16:05
@tschlenther
Copy link
Contributor Author

I resolved the issue #3548 by excluding activities in the damage calculation that are outside the grid, or more precisely by NOT mapping them to the closest grid cell.
I tested that via the NoiseDashboardTests, which use a mini Kelheim scenario. There, in local tests, I set the grid (via ShpOptions) to a small area which covers a highway. There are many noise immissions but no activities. See the red area in this screenshot as a reference (blue dots are home activities at hour 0)

Before this PR, the result would look like this

where you see that edge cells pointing towards Munich (south) etc have a high damage value.
After this PR, the result looks like this:

where you see no damage at all (there is no activity).

@tschlenther tschlenther enabled auto-merge November 7, 2024 16:18
@tschlenther tschlenther merged commit 85a74f7 into master Nov 7, 2024
49 checks passed
@tschlenther tschlenther deleted the noiseSubArea branch November 7, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant