Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freight: rename CarrierControler... to CarrierController... #3614

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

kt86
Copy link
Contributor

@kt86 kt86 commented Dec 1, 2024

..., rename package accordingly, and change usage of the (core) Controler to (core) Controller.

Also run "optimize imports" on the freight contrib.

@kt86 kt86 self-assigned this Dec 1, 2024
@kt86 kt86 linked an issue Dec 1, 2024 that may be closed by this pull request
@kt86
Copy link
Contributor Author

kt86 commented Dec 2, 2024

With this PR, we will fix the spelling error of controler in the freight contrib.
In contrast to the changes in core (see #3511), we do not provide the option for the controller with 'll'. We directly changed it. This avoids another step somewhere in the future and having both options flying around for the time being.
So in the end, this will be code-braking, at least due to the renaming of the package.
So please be aware of it @JWJoubert, @tschlenther

@kt86 kt86 marked this pull request as ready for review December 2, 2024 22:13
@kt86 kt86 enabled auto-merge December 2, 2024 22:14
@kt86 kt86 merged commit d60c92a into master Dec 2, 2024
49 checks passed
@kt86 kt86 deleted the 3513-freight-rename-carriercontrolerutils branch December 2, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freight: Rename CarrierControlerUtils ...
1 participant