pom.xml in contribs: use ${project.parent.version} for dependencys.. #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed version or ii) old, deprecated ${project.version}
kt86
deleted the
3575-poms-replace-hardcoded-version-by-projectparentversion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of i) hardcoded version or ii) old, deprecated ${project.version}.
Re i) As long as version change is done by search/replace, this will not directly change anything. But I think, it is less error-prone, that someone will forget some dependencies if not done so... This would lead to a version mixture.
With this change, this risk is significantly reduced.
Re ii) I updated the old, deprecated way of defining the dependency version, depending on the "parent" version.