Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freight (carrier): Rename internal variables and getter/setter to make them more consitent #3645

Merged
merged 15 commits into from
Dec 20, 2024
Merged

Freight (carrier): Rename internal variables and getter/setter to make them more consitent #3645

merged 15 commits into from
Dec 20, 2024

Conversation

kt86
Copy link
Contributor

@kt86 kt86 commented Dec 20, 2024

In this PR I changed the names of some variables and the corresponding getter and setter to make them more consistent between CarrierService and CarrierShipment.

I kept the old methods as deprecated for not breaking outside code.

Moreover, the XML-schemes were kept unchanged, until we decide, for a more general approach in defining the CarrierActivities (service, pickup, delivery).
See also #3601

kt86 added 15 commits December 20, 2024 12:40
@kt86
add getId() and getDemand() to interface
2c26b6a
@kt86
replace getSize() and getCapacityDemand() by new method getDemand()
9e964e0
@kt86
remove field name from CarrierService, incl. Builder
91a19fb
@kt86
reorder variables
701b615
@kt86
rename internal variables
e700fea
@kt86
make vars in Builder private
27984fa
@kt86
make id final
5d71e55
@kt86
make Builder constructor private, use available Builder.newInstance m…
da488be 
…ethod instead
@kt86
rename setters in Builder to make it more consistent. old setters rem…
10071db 
…ain as deprecated
@kt86
comments and javadoc
cbe5a12
@kt86
rename setter in Builder to make it more consistent. old setter remai…
b8c6da6 
…n as deprecated
@kt86
use new method names
80cc5df
@kt86
rename getters and setters to make it more consistent. old setters re…
8c5e2aa 
…main as deprecated
@kt86
rename getters and setters to make it more consistent. old setters re…
1eac344 
…main as deprecated
@kt86
reorganisation of code
9e65b09
@kt86 kt86 linked an issue Dec 20, 2024 that may be closed by this pull request
Rename things in CarrierService / CarrierShipment, to have this consistent. #3509
Closed
@kt86 kt86 mentioned this pull request Dec 20, 2024
Closed
@kt86
Copy link
Contributor Author

kt86 commented Dec 20, 2024

This PR will close #3509 and close #3600.

@kt86 kt86 enabled auto-merge December 20, 2024 14:14
@kt86 kt86 merged commit 1691f8a into master Dec 20, 2024
49 checks passed
@kt86 kt86 deleted the 3509-rename-things-in-carrierJobs branch December 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename things in CarrierService / CarrierShipment, to have this consistent.
1 participant
@kt86