Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drt for berlin v6.x #123

Merged
merged 9 commits into from
May 21, 2024
Merged

drt for berlin v6.x #123

merged 9 commits into from
May 21, 2024

Conversation

tschlenther
Copy link
Contributor

  1. Add OpenBerlinDrtScenario, which is a run class for drt loading
  2. an additional berlin-v6.1.drt-config.xml which only contains drt-specific and no duplicative stuff compared to base config
  3. all necessary input is provided via svn and all necessary base config adjustments are done in the OpenBerlinDrtScenario code

By default, a drt service in all of Berlin with 10,000 vehicles is simulated and configured to be perceived just like pt and to be fully tariff-integrated (@vsp-gleich maybe you can double-check??).

Currently, the following exception is thrown after iteration 0. @vsp-gleich can you help me with setting the marginal utility of travel time in the RaptorParameters?? Couldn't see how it's done by looking into the v5.x code....

java.lang.NullPointerException: Marginal utility of travel time is missing for mode: drt
	at ch.sbb.matsim.routing.pt.raptor.RaptorParameters.getMarginalUtilityOfTravelTime_utl_s(RaptorParameters.java:116) ~[matsim-16.0-PR3172.jar:?]
	at ch.sbb.matsim.routing.pt.raptor.DefaultRaptorIntermodalAccessEgress.calcIntermodalAccessEgress(DefaultRaptorIntermodalAccessEgress.java:50) ~[matsim-16.0-PR3172.jar:?]
	at ch.sbb.matsim.routing.pt.raptor.DefaultRaptorStopFinder.addInitialStopsForParamSet(DefaultRaptorStopFinder.java:258) ~[matsim-16.0-PR3172.jar:?]
	at ch.sbb.matsim.routing.pt.raptor.DefaultRaptorStopFinder.findIntermodalStops(DefaultRaptorStopFinder.java:146) ~[matsim-16.0-PR3172.jar:?]

There are a few ToDos, most importantly to implement tests ...

@tschlenther tschlenther requested review from rakow and vsp-gleich May 16, 2024 21:40
@tschlenther
Copy link
Contributor Author

Currently, the following exception is thrown after iteration 0. @vsp-gleich can you help me with setting the marginal utility of travel time in the RaptorParameters?? Couldn't see how it's done by looking into the v5.x code....

This issue is now solved. The simulation runs successfully.
DrtDashboard is created - I had to add a dependency for that.

@tschlenther
Copy link
Contributor Author

@vsp-gleich do you think we can merge? All checks have passed..

Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@tschlenther
Copy link
Contributor Author

I tried setting up a very simple (integration) test, but run into heap space issues. Let's get a student to set up a small test !?

@tschlenther tschlenther merged commit 0488d61 into main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants