Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag for initialReroute #39

Open
wants to merge 125 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
125 commits
Select commit Hold shift + click to select a range
df2738a
suggestion for first steps
kainagel Apr 13, 2023
5c4b0e3
suggestion for first steps
kainagel Apr 13, 2023
22bb72f
filter network
simei94 Apr 13, 2023
a144c12
Add examples dependency
rakow Apr 17, 2023
fba9c3e
Add files via upload
mkreuschner Apr 13, 2023
e453f38
commit test idea
GregorRyb Apr 17, 2023
050d95d
create sample population
simei94 Apr 18, 2023
2a3320c
first version that might structurally work. Still failing because of…
kainagel Apr 22, 2023
3008c74
changes around parking. pull up matsim version
kainagel Apr 24, 2023
5af8021
example for shp file based test
kainagel Apr 24, 2023
732849e
now seems to be working. Problem was that the chessboard example use…
kainagel Apr 25, 2023
34e20fc
add funtionality to tag residentialParking on persons
simei94 Apr 25, 2023
54ab7b8
start implementing assert statements
GregorRyb Apr 27, 2023
53c44e2
continued parking test, implemented normal to restricted
GregorRyb May 2, 2023
2f5184a
continued parking test
GregorRyb May 2, 2023
c8d006f
continued parking test, started with shopping still WIP
GregorRyb May 7, 2023
e4360b7
some comments
GregorRyb May 8, 2023
a0d2c3f
Merge branch 'main' into complicatedParking
rakow May 8, 2023
5ad0ab5
some refactoring
simei94 May 8, 2023
b7fa5f2
some refactoring
simei94 May 8, 2023
17dab7f
set parking link attr names to fixed from LeipzigUtils
simei94 May 8, 2023
18def97
Merge branch 'main' into complicatedParking
rakow May 9, 2023
0ec21c4
complete switch from parkingCostConfig to LeipzigUtils
simei94 May 9, 2023
f4ae00f
Merge remote-tracking branch 'origin/main' into complicatedParking
simei94 May 9, 2023
4e07fd5
first try to clean up test + algo class and apply a more specific nam…
simei94 May 9, 2023
157a86b
commercial traffic updates
rakow May 12, 2023
8ad10fc
remove unused imports
rakow May 12, 2023
ff887aa
Revert "first try to clean up test + algo class and apply a more spec…
simei94 May 16, 2023
bb684f4
make attr names non-editable
simei94 May 16, 2023
66120e8
finish up test case impl: renaming, create missing test cases
simei94 May 21, 2023
c7ad229
corrections on case parkingLogicLpz to parkingLogicLpz such that ther…
simei94 May 22, 2023
1d6dbd5
make getters for attr names package private
simei94 May 23, 2023
79c2282
remove unnecessary shoppingNetwork as this is done now differently
GregorRyb May 26, 2023
18be504
moved LeipzigRouterPlanAlgorithm
GregorRyb May 26, 2023
2d36bd2
extract and move LeipzigRoutingStrategyProvider
GregorRyb May 26, 2023
2c7f0ae
added parking to run class for a test run
GregorRyb May 26, 2023
81f3c76
comment + todo on vspDefaults
simei94 May 30, 2023
98523ea
checkstyle
simei94 May 30, 2023
0b826f3
bugfix
simei94 May 30, 2023
3e451f4
small changes to LeipzigRouterPlanAlgorithm, now getting parking beha…
GregorRyb May 31, 2023
a32798c
bugfix re assignment of parking cost
simei94 May 31, 2023
1fd6467
add routing mode to parkingBehaviour
GregorRyb May 31, 2023
4a2be42
parkingBehaviourType parkingSearchLogicLeipzig only for routingModes …
simei94 May 31, 2023
96462d2
enable parkingLogicLeipzig only for mode car
simei94 Jun 1, 2023
2e97a22
checkstyle
simei94 Jun 1, 2023
1b29d1d
better integration of the new ReRoute Strategy into the run class
GregorRyb Jun 4, 2023
b6b75e1
set name of new ReRouteStrategy in LeipzigRoutingStrategyProvider
GregorRyb Jun 5, 2023
009acc6
remove logging statements meant for debugging and add todo to the run…
GregorRyb Jun 5, 2023
ce2d73c
add leipzig prepare person for parking
rakow Jun 5, 2023
a02ff6b
Merge remote-tracking branch 'origin/complicatedParking' into complic…
rakow Jun 5, 2023
0aca292
modified PreparePersonForParking so we have the special parking logic…
GregorRyb Jun 6, 2023
55e0a50
fixed some style issues and suppressed the rest
GregorRyb Jun 12, 2023
6398482
Merge branch 'main' into complicatedParking
rakow Jun 13, 2023
6697c0b
Merge branch 'main' into complicatedParking
rakow Jun 13, 2023
676da51
Merge branch 'main' into complicatedParking
rakow Jun 13, 2023
f4f0687
fix wrong import
simei94 Jun 19, 2023
8e5ae50
Merge branch 'main' into complicatedParking
rakow Jun 19, 2023
40e7999
cleanup
rakow Jun 19, 2023
ef276d0
ensure xy2link in the parking preparation
rakow Jun 20, 2023
54478f1
Merge branch 'main' into complicatedParking
rakow Jun 20, 2023
2a06933
finished some todos
rakow Jun 20, 2023
7609796
Merge remote-tracking branch 'origin/complicatedParking' into complic…
rakow Jun 20, 2023
0535d22
fix checkstyle
rakow Jun 20, 2023
9d5a2ea
cleanup some style issues
rakow Jun 20, 2023
c5dfcf6
few more style fixes
rakow Jun 20, 2023
a10082f
Merge branch 'main' into v1.2
rakow Jun 20, 2023
dee681e
started with parking locations analysis
GregorRyb Jun 21, 2023
5f40aaa
setup trip dashboards
rakow Jun 21, 2023
e85f5c7
update calibrate script
rakow Jun 21, 2023
e8615ee
config update
rakow Jun 21, 2023
0b79dae
add subtour replanning that uses the leipzig re routing
rakow Jun 22, 2023
43ac678
adding counter to parking locations analysis
GregorRyb Jun 22, 2023
5abb6be
Merge branch 'main' into complicatedParking
GregorRyb Jun 22, 2023
61762ff
only adding the necessary nodes to the reduced network, to fix wrong …
GregorRyb Jun 27, 2023
924fef1
change method for checking if link is inside of geometry. it is more …
simei94 Jul 6, 2023
fefa202
commercial traffic updates
rakow May 12, 2023
7b6b287
remove unused imports
rakow May 12, 2023
d89b46d
setup trip dashboards
rakow Jun 21, 2023
faf8498
update calibrate script
rakow Jun 21, 2023
5f82184
config update
rakow Jun 21, 2023
1af6a8f
add subtour replanning that uses the leipzig re routing
rakow Jun 22, 2023
1211b7e
Merge branch 'v1.2' into complicatedParking
GregorRyb Jul 7, 2023
7b8daa0
fix shp path
rakow Jul 10, 2023
0e06e46
add shopping so agents who perform shopping activities can park in th…
GregorRyb Jul 10, 2023
e7c75e2
write out agents who perform parking activities
GregorRyb Jul 14, 2023
c1dea8e
fix networking filtering so we have no more issues with nodes being i…
GregorRyb Jul 17, 2023
6cc33f8
fix checkstyle issues
GregorRyb Jul 17, 2023
d7241e5
update config, added counts
rakow Jul 18, 2023
776a159
Merge pull request #35 from matsim-scenarios/complicatedParking
GregorRyb Jul 18, 2023
aac016a
update calibrate script
rakow Jul 18, 2023
38c4898
Merge remote-tracking branch 'origin/v1.2' into v1.2
rakow Jul 18, 2023
aadc2f5
reduce todo severity
rakow Jul 18, 2023
ae2e267
reduce todo severity
rakow Jul 18, 2023
8d03aed
update ride parameters
rakow Jul 18, 2023
1759112
annotate parking capacities with deprecated as it is not used anymore
GregorRyb Jul 26, 2023
79abaf5
update config and matsim version
rakow Aug 1, 2023
08b3ce7
fix typo
rakow Aug 1, 2023
e934e6f
make creation of DrtStops + intermodal TransitSchedule part of run cl…
simei94 Aug 28, 2023
be48cad
some cleanup
rakow Aug 29, 2023
4d6bd66
Merge branch 'main' into v1.2
rakow Aug 29, 2023
04e7c78
update matsim version
rakow Aug 29, 2023
f3016c1
add drt extensions for dashboards
rakow Aug 29, 2023
0c96462
fix imports
rakow Aug 29, 2023
556c448
added test for parking locations
GregorRyb Aug 29, 2023
fd15755
add TODO
simei94 Aug 31, 2023
cd06a3b
v1.2 routes ref
rakow Sep 5, 2023
3219b0c
Merge remote-tracking branch 'origin/v1.2' into v1.2
rakow Sep 5, 2023
ca82018
add enum case for teleported bike
simei94 Sep 21, 2023
50d35e5
python script to create reference data
rakow Oct 9, 2023
d0e251e
updated mode shares and scripts so that R and python is consistent
rakow Oct 16, 2023
f7ca93f
Merge branch 'main' into v1.2
rakow Oct 16, 2023
e3fbc12
switch back to specific PR version
rakow Oct 16, 2023
17aa185
Merge remote-tracking branch 'origin/v1.2' into v1.2
rakow Oct 16, 2023
66ff934
final mode share update
rakow Oct 23, 2023
e8a1e05
update initial asc
rakow Oct 23, 2023
a401753
update build scripts
rakow Oct 23, 2023
849f014
update config, small cleanup
rakow Oct 23, 2023
0263af8
remove import
rakow Oct 23, 2023
e7519ad
update calibrated parameters
rakow Oct 31, 2023
e484be7
update values
GregorRyb Nov 3, 2023
f4b8b49
add monetaryDistanceRate for ride
GregorRyb Nov 5, 2023
47b6617
use snz activity types for parking logic and tests
rakow Nov 21, 2023
c90772a
also update parking cost handler test
rakow Nov 21, 2023
ce85ca3
add parking test with leipzig run class
GregorRyb Nov 22, 2023
779246c
flag for initialReroute
tschlenther Nov 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,4 @@ jobs:
path: staging

env:
MAVEN_OPTS: -Xmx10G
MAVEN_OPTS: -Xmx512m
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

env:
MAVEN_OPTS: -Xmx10G
MAVEN_OPTS: -Xmx512m
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Add own ignores on top, don't edit the template

input/*stops.xml
input/*stops.csv
*.Rhistory
*.RProj




# Common files to ignore when working with matsim
Expand Down
30 changes: 18 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ osmosis := osmosis/bin/osmosis

NETWORK := germany-220327.osm.pbf
germany := ../shared-svn/projects/matsim-germany
shared := ../shared-svn/projects/NaMAV
shared ?= ../shared-svn/projects/NaMAV

.PHONY: prepare

Expand Down Expand Up @@ -70,13 +70,13 @@ input/sumo.net.xml: input/network.osm


input/$V/leipzig-$V-network.xml.gz: input/sumo.net.xml
$(sc) prepare network-from-sumo $< --output $@
$(sc) prepare network-from-sumo $< --output $@ --free-speed-factor 0.75
$(sc) prepare fix-network $@ --output $@
$(sc) prepare clean-network $@ --output $@ --modes bike

input/$V/leipzig-$V-network-with-pt.xml.gz: input/$V/leipzig-$V-network.xml.gz input/gtfs-lvb.zip
$(sc) prepare transit-from-gtfs --network $< $(filter-out $<,$^)\
--name leipzig-$V --date "2019-06-05" --target-crs $(CRS)\
--name leipzig-$V --date "2023-04-19" --target-crs $(CRS)\
--output input/$V

$(sc) prepare prepare-transit-schedule\
Expand All @@ -90,35 +90,36 @@ input/plans-longHaulFreight.xml.gz: input/$V/leipzig-$V-network.xml.gz
--input-crs $(CRS)\
--target-crs $(CRS)\
--shp ../shared-svn/projects/NaMAV/data/shapefiles/freight-area/freight-area.shp\
--cut-on-boundary\
--output $@

input/plans-commercialTraffic.xml.gz:
input/plans-completeSmallScaleCommercialTraffic.xml.gz:
$(sc) prepare generate-small-scale-commercial-traffic\
input/commercialTraffic\
--sample 0.25\
--jspritIterations 1\
--creationOption createNewCarrierFile\
--landuseConfiguration useOSMBuildingsAndLanduse\
--trafficType commercialTraffic\
--smallScaleCommercialTrafficType completeSmallScaleCommercialTraffic\
--zoneShapeFileName $(shared)/data/input-commercialTraffic/leipzig_zones_25832.shp\
--buildingsShapeFileName $(shared)/data/input-commercialTraffic/leipzig_buildings_25832.shp\
--landuseShapeFileName $(shared)/data/input-commercialTraffic/leipzig_landuse_25832.shp\
--shapeCRS "EPSG:25832"\
--resistanceFactor "0.005"\
--nameOutputPopulation $(notdir $@)\
--PathOutput output/commercialTraffic
--pathOutput output/commercialTraffic

mv output/commercialTraffic/$(notdir $@) $@

input/$V/leipzig-$V-25pct.plans-initial.xml.gz: input/plans-longHaulFreight.xml.gz input/plans-commercialTraffic.xml.gz
input/$V/leipzig-$V-25pct.plans-initial.xml.gz: input/plans-longHaulFreight.xml.gz input/plans-completeSmallScaleCommercialTraffic.xml.gz
$(sc) prepare trajectory-to-plans\
--name prepare --sample-size 0.25\
--max-typical-duration 0\
--output input/\
--population $(shared)/matsim-input-files/senozon/20210520_leipzig/population.xml.gz\
--attributes $(shared)/matsim-input-files/senozon/20210520_leipzig/personAttributes.xml.gz

$(sc) prepare population input/prepare-25pct.plans.xml.gz\
$(sc) prepare population input/prepare-25pct.plans.xml.gz --phase pre\
--shp $(shared)/matsim-input-files/senozon/20210520_leipzig/dilutionArea.shp --shp-crs $(CRS)\
--output input/prepare-25pct.plans.xml.gz

Expand All @@ -143,11 +144,16 @@ input/$V/leipzig-$V-25pct.plans-initial.xml.gz: input/plans-longHaulFreight.xml.

$(sc) prepare split-activity-types-duration\
--input input/prepare-25pct.plans-with-trips.xml.gz\
--exclude commercial_start,commercial_end,freight_start,freight_end\
--output $@

$(sc) prepare fix-subtour-modes --input $@ --coord-dist 100 --output $@
$(sc) prepare merge-populations $@ $^ --output $@

$(sc) prepare merge-populations $@ $< --output $@
$(sc) prepare population $@ --phase post\
--shp $(shared)/matsim-input-files/senozon/20210520_leipzig/dilutionArea.shp --shp-crs $(CRS)\
--output $@

$(sc) prepare fix-subtour-modes --input $@ --coord-dist 100 --output $@

$(sc) prepare extract-home-coordinates $@ --csv input/$V/leipzig-$V-homes.csv

Expand All @@ -166,8 +172,8 @@ check: input/$V/leipzig-$V-25pct.plans-initial.xml.gz
$(sc) analysis check-population $<\
--input-crs $(CRS)\
--attribute carAvail\
--shp ../shared-svn/projects/NaMAV/data/leipzig-utm32n/leipzig-utm32n.shp\
--shp ../shared-svn/projects/NaMAV/data/shapefiles/leipzig-utm32n/leipzig-utm32n.shp\

# Aggregated target
prepare: input/$V/leipzig-$V-25pct.plans-initial.xml.gz input/$V/leipzig-$V-network-with-pt.xml.gz
echo "Done"
echo "Done"
Binary file added input/v1.2/drtServiceArea/Leipzig_stadt.dbf
Binary file not shown.
Binary file added input/v1.2/drtServiceArea/Leipzig_stadt.shp
Binary file not shown.
Binary file added input/v1.2/drtServiceArea/Leipzig_stadt.shx
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
UTF-8
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PROJCS["ETRS_1989_UTM_Zone_32N",GEOGCS["GCS_ETRS_1989",DATUM["D_ETRS_1989",SPHEROID["GRS_1980",6378137.0,298.257222101]],PRIMEM["Greenwich",0.0],UNIT["Degree",0.0174532925199433]],PROJECTION["Transverse_Mercator"],PARAMETER["False_Easting",500000.0],PARAMETER["False_Northing",0.0],PARAMETER["Central_Meridian",9.0],PARAMETER["Scale_Factor",0.9996],PARAMETER["Latitude_Of_Origin",0.0],UNIT["Meter",1.0]]
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Loading