Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATSim version to 13.0 #9

Open
wants to merge 10 commits into
base: v1.1
Choose a base branch
from
Open

Update MATSim version to 13.0 #9

wants to merge 10 commits into from

Conversation

tschlenther
Copy link
Contributor

As addressed in #8 , the MATSim version 2020w15 that is referenced in the old pom.xml is not available any more.
Thus, an update to a more recent MATSim version is needed. This PR suggests to update to MATSim 13.0.

I fixed compilation errors related to

  1. activities now using the OptionalTime format
  2. Drt fares and DRT speed up were moved into the drt contrib and are now configured inside the DrtConfigGroup

I also pushed a folder for github workflow CI.

What remains to do (@ikaddoura):

  1. Update the (drt) configs
  2. Check the changes made related to activity times, especially for scoring!
  3. check tests

Best,

Tilmann

@tschlenther
Copy link
Contributor Author

maybe this should lead to a new verion for matsim-los-angeles.

Not sure, why the tests are not executed by the GitHub workflow. Maybe @rakow can help?

@rakow
Copy link

rakow commented Sep 6, 2021

What happens if you execute it locally?

mvn -Dtest=org.matsim.run.** test --batch-mode -Dmatsim.preferLocalDtds=true -Dmaven.javadoc.skip -e

@tschlenther
Copy link
Contributor Author

What happens if you execute it locally?

mvn -Dtest=org.matsim.run.** test --batch-mode -Dmatsim.preferLocalDtds=true -Dmaven.javadoc.skip -e

the same:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project matsim-los-angeles: No tests were executed!  (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project matsim-los-angeles: No tests were executed!  (Set -DfailIfNoTests=false to ignore this error.)

update surefire
update commons-io
@rakow
Copy link

rakow commented Sep 6, 2021

The tests run now but fail, please check the errors.

@ikaddoura
Copy link

Thanks @tschlenther and @rakow. I (hopefully) fixed the non-drt tests. The two drt-related tests are still failing. @tschlenther or @vsp-gleich, can you maybe have a look into these tests.

@sakibk005
Copy link

Hello, I was interested to see if there is any update on this task. While trying to install the existing version, I am getting the error that says 'Could not resolve dependencies for project com.github.matsim-scenarios:matsim-los-angeles:jar:v1.1: Failed to collect dependencies at com.github.matsim-vsp:drt-speed-up:jar:v0.0.3 -> org.matsim:matsim:jar:12.0-2020w15-SNAPSHOT:'

@tschlenther
Copy link
Contributor Author

i tried to push this forward a bit. Now my time is up. Currently stuck at multiple points:

  1. When running tests locally, RunDrtLosAngelesScenarioTest.test1() has heap space issues even though I have set mulitple GB for building
  2. When running tests locally, RunDrtLosAngelesScenarioTest.test2() complains about multiple binding for MainModeIdentifier, even though test1() did not ???
  3. GitHub actions workflow failed with Could not transfer artifact com.github.matsim-org:GTFS2MATSim:pom:20cc145c34 from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [ojo-snapshots (http://oss.jfrog.org/libs-snapshot, default, releases+snapshots)]. So I updated the gtfs2matsim dependency according to what we have in matsim-berlin and in matsim-kelheim. Now I get /home/runner/work/matsim-los-angeles/matsim-los-angeles/src/main/java/org/matsim/prepare/CreateTransitScheduleAndVehiclesFromGTFS.java:[32,30] error: cannot access RunGTFS2MATSim but not when building locally.

Will resume when I have more time. Maybe also @vsp-gleich or @rakow can help ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants