Get rid of ShipmentWithTime; Code cleanup in tests #293

kt86 · 2024-08-14T12:02:48Z

ShipmentWithTime was a tuple wrapping together a LspShipmentand a time (double value).

To reduce the code complexity, this is now gone, and the time is stored in an attribute of the LspShipment itself.

Moreover, I cleaned up a bit the code in the junit tests...

…longer exists

… there for make refactoring a bit easier.

kt86 added 21 commits August 14, 2024 12:10

store time in Attribute of LspShipment.

5fc4cec

move methods to Utils class

60b5140

WIP get rid of LspShipmentWithTime

4ff74c8

renaming

a0f4e18

IMO, after scheduling, the outgoingElements must contain the shipment.

caa9e38

simplify calls

37ffad7

simplify assertions

a1024e0

parameterized logging

cfdd81d

remove deprecated setting of vehType

aa704b4

remove unused variables

cd4e456

cleanup imports

38f18d9

improve tests

c513752

add not null check

463ec1f

java language level improvement

804b99d

fix typos

e2122a7

remove LspShipmentWithTime.java

908b496

fix typo

1476110

rename tuple to lspShipment, because the tuple "ShipmentWithTime" no …

9b2e27c

…longer exists

remove unused var from method signature

1f901f0

some encapsulation. fix and comment test

28217d0

remove the temporarily added get/setTime(..) methods. They where only…

d583037

… there for make refactoring a bit easier.

kt86 enabled auto-merge August 14, 2024 12:42

kt86 merged commit b052bd9 into main Aug 14, 2024
1 check passed

kt86 deleted the kmt_2echelon4Diss branch August 14, 2024 12:47

Provide feedback