Update the badge position more frequently #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @matteogobbi @SilkyPantsDan @swoolcock |
matteogobbi
reviewed
Feb 9, 2018
| @@ -42,6 +42,8 @@ - (instancetype)initWithFrame:(CGRect)frame { | |||
| } | |||
|
|
|||
| - (void)drawRect:(CGRect)rect { | |||
| [self mg_updateBadgeViewSize]; | |||
| [self mg_updateBadgeViewPosition]; | |||
There was a problem hiding this comment.
I don't think the 2 lines above are necessary and I would prefer to not have these calls here.
matteogobbi
requested changes
Feb 9, 2018
|
|
||
| if(_position == MGBadgePositionBest) | ||
| [self mg_updateBadgeViewPosition]; | ||
| [self mg_updateBadgeViewPosition]; |
There was a problem hiding this comment.
This is not needed if the position isn't best.
You probably want put back the old code and add a call to mg_updateBadgeViewSize (for all the changes from here to the end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of issues were raised related to the badge position not working: #3, #4 and #7. This fixes that.
Basically, always update the position, and updated before drawing also.