-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes broken logging and adds structure to logs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
force-pushed
the
db/fix-and-improve-debugging-logs
branch
from
November 23, 2024 17:16
15b01bc
to
6a5c7af
Compare
dutterbutter
force-pushed
the
db/fix-and-improve-debugging-logs
branch
from
November 28, 2024 20:55
903eaae
to
aa7c660
Compare
dutterbutter
force-pushed
the
db/fix-and-improve-debugging-logs
branch
from
November 29, 2024 17:02
aa7c660
to
ddd0239
Compare
@Romsters please review at your convenience |
Romsters
reviewed
Dec 3, 2024
Romsters
previously approved these changes
Dec 3, 2024
Romsters
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step towards an improved debugging experience.
What 💻
--show-storage-logs
,--show-vm-details
, and--show-gas-details
CLI options added back-d
to be user focused--show-event-logs
so they too can be configurableFormatter
impl to manage structured logsWhy ✋
Usage
rm -rf .cache
For ALL calls (can also specify just user):
./target/release/era_test_node --show-calls=all --resolve-hashes=true run
--show-outputs=true
For events:
./target/release/era_test_node --show-event-logs=true --resolve-hashes=true run
For gas:
./target/release/era_test_node --show-gas-details=all run
For Storage logs (Write view)
./target/release/era_test_node --show-storage-logs=write run
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intendedBefore ALL call stack:
Improved All Call Stack Log:
Events:
Gas Details LOTS of improvement can be done here!
VM Execution details
Write Storage Logs