feat: add --no-mine mode
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
approved these changes
Nov 28, 2024
| .with_value(U256::from(100)); | ||
| let pending_tx = provider.send_transaction(tx).await?.register().await?; | ||
| let finalization_result = tokio::time::timeout(Duration::from_secs(3), pending_tx).await; | ||
| assert!(finalization_result.is_err()); |
There was a problem hiding this comment.
Can we force block to seal? If so, it would be nice to add it to this test too to make sure that the node doesn't just hang
There was a problem hiding this comment.
We can seal a block manually but it won't have the tx in it (see https://github.com/matter-labs/era-test-node/issues/404). I am hoping to address this shortly and will update this test then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Closes #405
Adds
--no-mineCLI param that stops the node from sealing blocks automatically.Why ✋
Feature parity with anvil