fix: make manual mining produce non-empty blocks #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
reviewed
Dec 2, 2024
| .next() | ||
| .expect("unexpected failure, value must exist"); | ||
|
|
||
| tracing::info!("Reverting node to snapshot '{snapshot_id:?}'"); |
There was a problem hiding this comment.
Throughout snapshot / mining modes we are using tracing::info!, do we want these to be written out by default? I know we want to move away from tracing::info all together but curious your thoughts on outputting this information.
There was a problem hiding this comment.
Yeah I am not adding new tracing::info, this line existed before this PR and I think we should refactor logging in a separate PR to reduce the noise.
Generally speaking IMO we should only use tracing::trace or tracing::debug.
dutterbutter
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Closes #404
Why ✋
Correct behavior expected by users