-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improves error messaging for better debugging #468
Conversation
// TODO: Ask if vm.inspect is the same as vm.execute | ||
let tx_result = vm.inspect(&mut tracers.into(), InspectExecutionMode::OneTx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itegulov do you know if calling vm.inspect
vs vm.execute
makes any difference? It doesnt seem so but wanted to confirm.
) -> ( | ||
VmExecutionResultAndLogs, | ||
Vec<Call>, | ||
ErrorFlags, | ||
BootloaderDebug, | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont love returning this tuple from here, but unsure how else to make it work
Very cool! Can we make Also, controversial, but not all terminals support emoji. Can we find an ascii/utf8 replacement for 🔴 ? |
Thanks for the feedback! Yes, certainly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the massive amount of conflicts, completely missed this PR! I think this is still useful and lmk if you need help with rebasing the changes on the new project structure.
What 💻
CallErrorTracer
Logging and Update Revert/Halt Handling #436Why ✋
Evidence 📷
Contract reversion error:
Paymaster error:
Function selector error: