Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix issue with gas params #471

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: fix issue with gas params #471

merged 2 commits into from
Dec 4, 2024

Conversation

dutterbutter
Copy link
Collaborator

What 💻

  • Fix issue with gas params always using default values
  • Fix issue with never using forked gas params due to default values superseding
  • Remove unwanted log
  • Respects offline usage

Why ✋

  • Should use most accurate gas params
  • Log shouldnt be there
  • Offline was not accounted for in config

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter requested a review from a team as a code owner December 4, 2024 17:37
@dutterbutter dutterbutter requested a review from Romsters December 4, 2024 17:37
@dutterbutter dutterbutter merged commit def668a into main Dec 4, 2024
13 checks passed
@dutterbutter dutterbutter deleted the db/fix-forked-chain-id branch December 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romsters Romsters Romsters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutterbutter @Romsters