feat: add cli options for server configuration #487
Conversation
Added e2e tests |
| @@ -93,6 +101,66 @@ pub async fn init_testing_provider( | |||
| }) | |||
| } | |||
|
|
|||
| // Init testing provider which sends specified HTTP headers e.g. for authentication | |||
| // Outside of `TestingProvider` to avoid specifying `P` | |||
There was a problem hiding this comment.
Can we solve it by using Box<dyn FullZksyncProvider<T>> instead of template parameters?
Transport can also be erased by using Box<dyn Transport + Clone>.
There was a problem hiding this comment.
Possibly, but we already have the default init_testing_provider function which I copied. Can be refactored though.
| @@ -93,6 +101,66 @@ pub async fn init_testing_provider( | |||
| }) | |||
| } | |||
|
|
|||
| // Init testing provider which sends specified HTTP headers e.g. for authentication | |||
| // Outside of `TestingProvider` to avoid specifying `P` | |||
| pub async fn init_testing_provider_with_http_headers( | |||
There was a problem hiding this comment.
Also, isn't it possible to express the logic of adding headers as a fn add_headers(EraTestNode) -> EraTestNode, so that this method is not needed at all? Then you will be able to use init_testing_provider(add_headers) or smth.
Note that function is composable, so we can wrap any number of layers here, e.g. init_testing_provider(|node| f1(f2(node)))
There was a problem hiding this comment.
No, because it's not the setting on the node, it's the setting on provider.
There was a problem hiding this comment.
We could extend the provider code of on_era_test_node_with_wallet_and_config fn or add another one on the alloy-zksync side, but didn't want to do that as not sure if it is useful for any other cases.
What 💻
Added
--allow-origincli option;Added
--no-corscli option;Why ✋
Feature parity with anvil;