-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker build for amd64 / arm64, e2e tests, publishing ghcr #503
Conversation
β¦er node, publishes to ghcr
us-docker.pkg.dev/matterlabs-infra/matterlabs-docker/era-test-node:${{ steps.docker_tag.outputs.tag }} | ||
us-docker.pkg.dev/matterlabs-infra/matterlabs-docker/era-test-node:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@popzxc how can we update this to be anvil-zksync
instead of era-test-node
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just try changing the name first and see if that will work. The way I am parsing this string is matterlabs-infra
is the name of project, matterlabs-docker
is the name of the container registry and era-test-node
is the image in the registry. AFAIR you should be able to add new images to an existing registry by default unless we have disabled that on purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can temporarily enable on.push.branches.<your-branch-name>
to make this trigger before we merge the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β¦il-zksync into db/multi-platform-docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@itegulov I want to test this again on a fork before merging. @antonbaliasnikov has pointed out that with using the same tag it might just overwrite the last job that completes. |
What π»
Why β
Closes #479, Closes #480, Closes #481
Evidence π·
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intended