fix: remove value variable from the CheckBoxInput component

matter-labs · Feb 5, 2024 · 82b5353 · 82b5353
1 parent 3688a42
commit 82b5353
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/packages/app/src/components/common/CheckBoxInput.stories.ts b/packages/app/src/components/common/CheckBoxInput.stories.ts
@@ -6,7 +6,6 @@ export default {
 };
 
 type Args = {
-  value: boolean;
   modelValue: boolean;
 };
 
@@ -21,12 +20,10 @@ const Template = (args: Args) => ({
 
 export const Checked = Template.bind({}) as unknown as { args: Args };
 Checked.args = {
-  value: true,
   modelValue: true,
 };
 
 export const Unchecked = Template.bind({}) as unknown as { args: Args };
 Unchecked.args = {
-  value: false,
   modelValue: false,
 };
diff --git a/packages/app/src/components/common/CheckBoxInput.vue b/packages/app/src/components/common/CheckBoxInput.vue
@@ -1,6 +1,6 @@
 <template>
-  <label class="checkbox-input-container" :class="{ checked: value }">
-    <input type="checkbox" :checked="value" v-model="inputted" v-bind="$attrs" />
+  <label class="checkbox-input-container" :class="{ checked: inputted }">
+    <input type="checkbox" :checked="inputted" v-model="inputted" v-bind="$attrs" />
     <slot />
   </label>
 </template>
@@ -18,10 +18,6 @@ const props = defineProps({
     type: Boolean,
     default: null,
   },
-  value: {
-    type: Boolean,
-    required: true,
-  },
 });
 const emit = defineEmits<{
   (eventName: "update:modelValue", value: unknown): void;

diff --git a/packages/app/src/views/ContractVerificationView.vue b/packages/app/src/views/ContractVerificationView.vue
@@ -112,7 +112,6 @@
           <CheckBoxInput
             v-if="selectedCompiler.name === CompilerEnum.solc"
             v-model="isZkVMSolcCompiler"
-            :value="false"
             @update:model-value="onZkVMSelectionChanged"
             >{{ t("contractVerification.form.solcVersion.zkVM") }}</CheckBoxInput
           >

diff --git a/packages/app/tests/components/common/CheckBoxInput.spec.ts b/packages/app/tests/components/common/CheckBoxInput.spec.ts
@@ -13,7 +13,7 @@ describe("CheckBoxInput", () => {
         },
       },
       props: {
-        value: true,
+        modelValue: true,
       },
     });
     expect(container.textContent).toBe("CheckBox Input");
@@ -22,7 +22,6 @@ describe("CheckBoxInput", () => {
     const { container } = render(CheckBoxInput, {
       props: {
         modelValue: true,
-        value: true,
       },
     });
     expect(container.querySelector(".checkbox-input-container")!.classList.contains("checked")).toBe(true);
@@ -32,7 +31,6 @@ describe("CheckBoxInput", () => {
     const { container } = render(CheckBoxInput, {
       props: {
         modelValue: false,
-        value: false,
       },
     });
     expect(container.querySelector(".checkbox-input-container")!.classList.contains("checked")).toBe(false);