Skip to content

Commit

Permalink
fix: docs links (#150)
Browse files Browse the repository at this point in the history
# What ❔

Fix links to documentation.

## Why ❔

The documentation has been updated so we should use new links.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [X] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [X] Tests for the changes have been added / updated.
  • Loading branch information
vasyl-ivanchuk authored Jan 16, 2024
1 parent 0c0c6bf commit f0a30db
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 14 deletions.
4 changes: 2 additions & 2 deletions packages/app/src/components/FeeData.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<div>
<a
class="refunded-link"
href="https://era.zksync.io/docs/dev/developer-guides/transactions/fee-model.html#refunds"
href="https://docs.zksync.io/build/developer-reference/fee-model.html#refunds"
target="_blank"
>{{
t(
Expand All @@ -40,7 +40,7 @@
<a
v-if="feeData?.isPaidByPaymaster"
class="paymaster-link"
href="https://era.zksync.io/docs/reference/concepts/account-abstraction.html#paymasters"
href="https://docs.zksync.io/build/developer-reference/account-abstraction.html#paymasters"
target="_blank"
>{{ t("transactions.table.feeDetails.whatIsPaymaster") }}</a
>
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/TheFooter.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const config = useRuntimeConfig();
const navigation = reactive([
{
label: computed(() => t("footer.nav.docs")),
url: "https://era.zksync.io/docs/dev/",
url: "https://docs.zksync.io/build/tooling/block-explorer/getting-started.html",
},
{
label: computed(() => t("footer.nav.terms")),
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/header/TheHeader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const { currentNetwork } = useContext();
const navigation = reactive([
{
label: computed(() => t("header.nav.documentation")),
url: "https://era.zksync.io/docs/dev/",
url: "https://docs.zksync.io/build/tooling/block-explorer/getting-started.html",
},
]);
Expand Down
4 changes: 2 additions & 2 deletions packages/app/src/views/ContractVerificationView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<Alert type="notification" class="full-grid-width">
<i18n-t scope="global" keypath="contractVerification.resources.title" tag="span">
<template #hardhat>
<a href="https://era.zksync.io/docs/tools/hardhat/hardhat-zksync-verify.html" target="_blank">
<a href="https://docs.zksync.io/build/tooling/hardhat/hardhat-zksync-verify.html" target="_blank">
{{ t("contractVerification.resources.links.hardhat") }}
</a>
</template>
Expand Down Expand Up @@ -84,7 +84,7 @@
class="label-inline-block"
>
<a
href="https://era.zksync.io/docs/tools/block-explorer/contract-verification.html#enter-contract-details"
href="https://docs.zksync.io/build/tooling/block-explorer/contract-verification.html#user-interface"
target="_blank"
class="docs-link"
>{{ t(`contractVerification.form.${selectedZkCompiler.name}Version.details`) }}</a
Expand Down
6 changes: 3 additions & 3 deletions packages/app/tests/components/FeeData.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ describe("FeeToken", () => {
await fireEvent.click(container.querySelector(".toggle-button")!);
const link = container.querySelector(".refunded-link");
expect(link?.getAttribute("href")).toBe(
"https://era.zksync.io/docs/dev/developer-guides/transactions/fee-model.html#refunds"
"https://docs.zksync.io/build/developer-reference/fee-model.html#refunds"
);
expect(link?.getAttribute("target")).toBe("_blank");
expect(link?.textContent).toBe("Why am I being refunded?");
Expand Down Expand Up @@ -240,14 +240,14 @@ describe("FeeToken", () => {

const refundedLink = container.querySelector(".refunded-link");
expect(refundedLink?.getAttribute("href")).toBe(
"https://era.zksync.io/docs/dev/developer-guides/transactions/fee-model.html#refunds"
"https://docs.zksync.io/build/developer-reference/fee-model.html#refunds"
);
expect(refundedLink?.getAttribute("target")).toBe("_blank");
expect(refundedLink?.textContent).toBe("Why is Paymaster being refunded?");

const paymasterLink = container.querySelector(".paymaster-link");
expect(paymasterLink?.getAttribute("href")).toBe(
"https://era.zksync.io/docs/reference/concepts/account-abstraction.html#paymasters"
"https://docs.zksync.io/build/developer-reference/account-abstraction.html#paymasters"
);
expect(paymasterLink?.getAttribute("target")).toBe("_blank");
expect(paymasterLink?.textContent).toBe("What is Paymaster?");
Expand Down
4 changes: 3 additions & 1 deletion packages/app/tests/components/TheFooter.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ describe("TheFooter:", () => {
},
});
const links = wrapper.findAll("a");
expect(links[0].attributes("href")).toBe("https://era.zksync.io/docs/dev/");
expect(links[0].attributes("href")).toBe(
"https://docs.zksync.io/build/tooling/block-explorer/getting-started.html"
);
expect(links[1].attributes("href")).toBe("https://zksync.io/terms");
expect(links[2].attributes("href")).toBe("https://zksync.io/contact");
});
Expand Down
2 changes: 1 addition & 1 deletion packages/app/tests/components/TheHeader.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe("TheHeader:", () => {
expect(toolsLinks[2].attributes("href")).toBe("https://portal.zksync.io/");

expect(wrapper.findAll(".navigation-container > .navigation-link")[0].attributes("href")).toBe(
"https://era.zksync.io/docs/dev/"
"https://docs.zksync.io/build/tooling/block-explorer/getting-started.html"
);
});
it("renders social links", () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Feature: Redirection

Examples:
| Extra button name | url |
| Docs | https://era.zksync.io/docs/dev/ |
| Docs | https://docs.zksync.io/build/tooling/block-explorer/getting-started.html |
| Terms | https://zksync.io/terms |
| Contact | https://zksync.io/contact |

Expand All @@ -32,7 +32,7 @@ Feature: Redirection
@id251
Scenario: Verify redirection for Documentation link
Given I click by text "Documentation"
Then New page have "https://era.zksync.io/docs/dev/" address
Then New page have "https://docs.zksync.io/build/tooling/block-explorer/getting-started.html" address

@id252
Scenario Outline: Verify redirection for "<Sub-Section>" in BE menu
Expand Down
2 changes: 1 addition & 1 deletion packages/app/tests/views/ContractVerificationView.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ describe("ContractVerificationView:", () => {

expect(wrapper.find(".docs-link").text()).toEqual("Details");
expect(wrapper.find(".docs-link").attributes("href")).toEqual(
"https://era.zksync.io/docs/tools/block-explorer/contract-verification.html#enter-contract-details"
"https://docs.zksync.io/build/tooling/block-explorer/contract-verification.html#user-interface"
);
});
it("resets uploaded files block when clicking on clear button", async () => {
Expand Down

0 comments on commit f0a30db

Please sign in to comment.