fix: ignore parse log errors #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a4618f5):
(expires Sat, 16 Dec 2023 00:01:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
vasyl-ivanchuk
approved these changes
Dec 11, 2023
|
🎉 This PR is included in version 2.35.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
pcheremu
pushed a commit
that referenced
this pull request
Feb 15, 2024
# What ❔ - show logs without parsed event if it fails. ## Why ❔ - currently it shows no logs at all if even one of many logs is failed to parse. This is a quick fix for now. The issue can be reproduced with proxy contracts if there are some events emitted which are defined in the implementation contract. To properly fix it we should use both proxy and implementation ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
This is a quick fix for now. The issue can be reproduced with proxy contracts if there are some events emitted which are defined in the implementation contract. To properly fix it we should use both proxy and implementation ABI.