test: rebase2 be tests #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What ❔ - validate bridge init log to be produced by bridge contract ## Why ❔ - if token is bridged outside of bridge it can't rely on provided token l1 address
# What ❔ 1. Remove new prover notification since it's not needed anymore. 2. Add Sepolia Testnet production configuration. ## Why ❔ We need a Sepolia block explorer production environment to eventually use it as a main Testnet environment. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ - add coingecko tokens off-chain data provider ## Why ❔ - to support both L1 and L2 zksync tokens ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [+ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ +] Tests for the changes have been added / updated.
# What ❔ Hide Sepolia network on prod. ## Why ❔ We need to hold off on announcing Sepolia support in Block Explorer until all other teams are ready to do this. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ Renamed tokens page title to "To tokens" ## Why ❔ We show only top tokens there, not all of them
…ches/blocks (#107) # What ❔ Different _no transaction_ messages for non-existing and empty batches/blocks: Empty batch: <img width="1259" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/b3f8d9fc-dee8-4178-91c3-26eaff3be660"> Non-existing batch: <img width="1263" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/da083f5f-c887-41f0-9173-0c51064fca91"> ## Why ❔ For better UX we want to show different _no transaction_ messages in different cases: `This Batch doesn’t have any transactions` - for empty batch, `This Batch has not been created or sealed yet` - for non-existing batch, same for blocks. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ Enable sepolia network on prod. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
…erGas fields for transaction (#109) # What ❔ Return `gasUsed`, `gasPerPubdata`, `maxFeePerGas` and `maxPriorityFeePerGas` fields for transaction. ## Why ❔ For better UX we want to show gas and fee related fields on UI so we need to return these fields from the API first. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ - fetch and store tx error and revert reason; - return tx error and revert reason via API; - display tx error on UI; ## Why ❔ - fast way to see what's the reason of transaction failure; ## Checklist - [+] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [+] Tests for the changes have been added / updated. - [+] Documentation comments have been added / updated.
# What ❔ Sepolia staging hostname. - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs).
# What ❔ - remove $ from copy-pasteable commands - add sepolia links
# What ❔ <img width="441" alt="image" src="https://github.com/matter-labs/block-explorer/assets/6553665/b69c7a82-4f3a-4afa-abc5-8b7385a5079d"> ## Why ❔ For better user experience it was requested to show gas fields and limits on UI. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
…d of a separate call (#115) # What ❔ Api contract endpoint to use `creatorAddress` field instead of a separate DB call to fetch txReceipt. ## Why ❔ We don't need a DB call to fetch contract creator address. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
# What ❔ update ui tests for sepolia ## Why ❔ keep tests up to date ## Checklist - [+ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ +] Tests for the changes have been added / updated. - [- ] Documentation comments have been added / updated.
# What ❔ - show logs without parsed event if it fails. ## Why ❔ - currently it shows no logs at all if even one of many logs is failed to parse. This is a quick fix for now. The issue can be reproduced with proxy contracts if there are some events emitted which are defined in the implementation contract. To properly fix it we should use both proxy and implementation ABI.
# What ❔ - Save tokens which affected balances after processing every block. ## Why ❔ - If token initially deployed didn't have all the required attributes we need to try to save it again later. ## Checklist - [+] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [+] Tests for the changes have been added / updated.
# What ❔ Use liquidity tokens filter only on mainnet. ## Why ❔ To show tokens without liquidity on testnets, local envs and hyperchains. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [X] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [X] Tests for the changes have been added / updated.
Removed obsolete Wallet import
Fixed text suites/cases naming, adjusted beforeAll preconditions, added more checks to Logs TC
pcheremu
added
duplicate
|
Visit the preview URL for this PR (updated for commit ecea709):
(expires Thu, 21 Dec 2023 13:26:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
vasyl-ivanchuk
approved these changes
Dec 15, 2023
abilevych
approved these changes
Dec 15, 2023
This was referenced Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
rebase integration test branch to main
Why ❔
to keep up to date
Checklist