-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: retry wrapper over api requests #149
chore: retry wrapper over api requests #149
Conversation
API E2E Test Results206 tests 206 ✅ 28s ⏱️ Results for commit d23bd9b. ♻️ This comment has been updated with latest results. |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit ecce757. |
Unit Test Results 3 files 247 suites 8m 45s ⏱️ Results for commit d23bd9b. ♻️ This comment has been updated with latest results. |
Visit the preview URL for this PR (updated for commit d23bd9b):
(expires Wed, 31 Jan 2024 09:11:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
7d22416
to
276ab27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make the review one more time tomorrow morning with fresh feelings. For now tests looks good and the logic is elegant. No idea if we need to worry about it or 200 iterations with low latency is preferable than longer latency with less amount of iterations. I have also noticed that (despite on some excluded tests) the total time for api tests was decreased ~ on 23% (from 17min to 13min).
What ❔
The API retry logic for integration tests
Why ❔
It allows increase speed of test runs due to refusing the timeouts-based approach
Checklist