Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry wrapper over api requests #149

Merged
merged 16 commits into from
Jan 24, 2024

Conversation

abilevych
Copy link
Contributor

@abilevych abilevych commented Jan 11, 2024

What ❔

The API retry logic for integration tests

Why ❔

It allows increase speed of test runs due to refusing the timeouts-based approach

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@abilevych abilevych changed the base branch from main to integration-tests January 11, 2024 14:01
@abilevych abilevych added the automation writing/fixing/maintaining auto-tests/e2e-tests label Jan 11, 2024
Copy link

github-actions bot commented Jan 11, 2024

API E2E Test Results

206 tests   206 ✅  28s ⏱️
 14 suites    0 💤
  1 files      0 ❌

Results for commit d23bd9b.

♻️ This comment has been updated with latest results.

Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ecce757.

Copy link

github-actions bot commented Jan 11, 2024

Unit Test Results

    3 files    247 suites   8m 45s ⏱️
1 970 tests 1 969 ✅ 1 💤 0 ❌
1 996 runs  1 995 ✅ 1 💤 0 ❌

Results for commit d23bd9b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 11, 2024

Visit the preview URL for this PR (updated for commit d23bd9b):

(expires Wed, 31 Jan 2024 09:11:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e508f9012944951194447cb8885950b451a24403

@abilevych abilevych force-pushed the QA-582-retry-wrapper-over-API-requests branch from 7d22416 to 276ab27 Compare January 18, 2024 14:16
@abilevych abilevych requested a review from pcheremu January 23, 2024 13:36
Copy link
Contributor

@pcheremu pcheremu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make the review one more time tomorrow morning with fresh feelings. For now tests looks good and the logic is elegant. No idea if we need to worry about it or 200 iterations with low latency is preferable than longer latency with less amount of iterations. I have also noticed that (despite on some excluded tests) the total time for api tests was decreased ~ on 23% (from 17min to 13min).

@abilevych abilevych merged commit eb0e8b6 into integration-tests Jan 24, 2024
35 checks passed
@abilevych abilevych deleted the QA-582-retry-wrapper-over-API-requests branch January 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation writing/fixing/maintaining auto-tests/e2e-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants